Re: [PATCH] Fix ability to use ECDSA host keys

[Alan Dunn <amdunn@xxxxxxxxx>]

With this patch and my prior, and minor changes to samplesshd to use
ECDSA keys (which I have not yet submitted), samplesshd can use ECDSA
keys successfully in my environment.

On Sat, Feb 15, 2014 at 1:25 PM, Dustin Oprea <myselfasunder@xxxxxxxxx> wrote:
> The host-keys and authentication now work, in your environment?
>
> Dustin
>
> On Feb 15, 2014 2:17 PM, "Alan Dunn" <amdunn@xxxxxxxxx> wrote:
>>
>> Hi folks,
>>
>> After our previous discussion on the inability to enable ECDSA keys, I
>> found some bugs in how they are actually used in libssh (even if one
>> were able to enable them).  With these changes, and some version of
>> changes to allow ECDSA host keys to be enabled (I used my prior patch
>> for testing and added an option to samplesshd), I was able to
>> successfully get examples sample and samplesshd to communicate, as
>> well as an OpenSSH client and samplesshd.
>>
>> There were two issues:
>> - ecdsa_nid was not copied to duplicated ECDSA private keys
>> - SHA-2 hashing was not used for sessionid generation for ECDSA keys
>> (instead SHA-1 was being used)
>>
>> Thanks,
>> - Alan