Re: [PATCH] basic client certificate support for libssh

[Axel Eppe <aeppe@xxxxxxxxxx>]

Hi Andreas,

Apologies for the long silence. I finally got around reviewing this patch
again and added tests for the new code.

I have now also added cert specific functions for import, instead of using
the pubkey functions. I believe this will make extensions (key types,
server, ...) simpler, and is probably more intuitive to use. Currently most
of the added functions simply forward the call to their pubkey counterpart.

The new patch should be in sync (or very close) to master.

Thanks for your feedback,
Axel


On Fri, Mar 6, 2015 at 10:14 AM, Andreas Schneider <asn@xxxxxxxxxxxxxx>
wrote:

> On Sunday 01 March 2015 17:22:29 Axel Eppe wrote:
> > Hi,
>
> Hi Axel,
>
> > Please find attached a patch that adds basic openssh.com certificate
> > support for libssh clients. This patch is very simple and key type
> > agnostic: it sends the certificate blob as-is to the server, instead of
> the
> > public key. This can be a first step before a more in-depth certificate
> > support that includes the server side as well.
>
> thank you very much for your contribution. I don't have time to look into
> at
> the moment. I hope I find time for libssh in 2 weeks again.
>
> Could you please add unit tests for the code you added? Also a git format-
> patch would be nice.
>
>
> Thanks,
>
>
>         -- andreas
>
>
> --
> Andreas Schneider                   GPG-ID: CC014E3D
> www.cryptomilk.org                asn@xxxxxxxxxxxxxx
>
>

Attachment: 0001-Basic-client-side-RSA-DSA-certificate-authentication.patch
Description: Binary data