Re: Patch: Add X11 forwarding support for ssh client

[Vic Lee <llyzs@xxxxxxx>]

Hi,
Did you already reply to my email? I think I had problem with the
mailing list and probably missed some emails. But I already register
another email address and hopefully I won't miss anything again.

If you already replied to my email please send again. Sorry for the
inconvient. Thanks.

Vic

On Thu, 2009-07-30 at 22:21 +0800, Vic Lee wrote:
> Hi,
> Here's the patch based on the latest (Preston's great work). It works
> just fine without changing messages.c :) So I even tested it by
> tunnelling a "gimp" from a remote computer :))
> 
> Probably, I will submit a complete x11 tunnelling client demo in another
> separated patch later when I got some time.
> 
> Vic
> 
> On Tue, 2009-07-28 at 12:47 -0400, Preston A. Elder wrote:
> > Vic,
> > 
> > Could you please remove your messages.c part?  I am about to resubmit my
> > server enhancements patch, and it has the messages.c part for x11.  More
> > importantly, it actually implements it properly.  Your implementation
> > does not populate the originator or originator port, which are sent in
> > the X11 forward request, and should be set in the channel_request_open
> > structure so that the programmer handling the SSH_CHANNEL_X11 can make a
> > decision based on who the originator was.
> > 
> > If you just submit without the 'server side' support then my patch will
> > implement the X11 server side stuff just fine without conflict :)
> > 
> > Preston.
> > 
> > Vic Lee wrote:
> > > Hi,
> > >
> > > I finally completed the X11 forwarding feature. Here is the patch
> > > attached. Just to save your time review it, I will explain a little bit:
> > > 1. some codes were added to messages.c in order to recognize "x11"
> > > channel open request from the server
> > > 2. Two new API were added:
> > > channel_request_x11: send the "x11-req" channel request to the server
> > > channel_accept_x11: wait for an incoming x11 channel from the server, or
> > > until a certain timeout.
> > > 3. In order to use functions from messages.c, I have to include server.h
> > > in channels.c
> > >
> > > That's it, quite simple.
> > >
> > > Thanks,
> > >
> > > Vic
> > >   
> > 
> >