Re: Segfaults in Windows 7

[Andreas Schneider <asn@xxxxxxxxxxxx>]

On Thursday 12 August 2010 22:27:11 you wrote:
> I have started doing some testing of my application under Windows 7, but I
> am seeing some seg faults in libssh. The application runs fine under Linux
> and Windows XP.

Could you try the following patch?

http://git.libssh.org/users/asn/libssh.git/commit/?id=46e15d75b9f8700ab19fb542169b01ca86de23de

I think this is ticket #101

http://dev.libssh.org/ticket/101

> I am using libssh-mingw4-20100808-bin (0.4.5).
> 
> This seg fault occurs will I am doing channel I/O for a terminal:
> 
> Program received signal SIGSEGV, Segmentation fault.
> 0x61ad7575 in packet_read2 () from H:\freepascal\RAT\Work\trash\libssh.dll
> (gdb) backtrace
> #0  0x61ad7575 in packet_read2 () from
> H:\freepascal\RAT\Work\trash\libssh.dll
> #1  0x61ad8f28 in ssh_handle_packets () from
> H:\freepascal\RAT\Work\trash\libssh.dll
> #2  0x61ac5177 in channel_poll () from
> H:\freepascal\RAT\Work\trash\libssh.dll
> #3  0x0042adf7 in TSSHTERMINALHELPER__TERMINALRECEIVE (this=0x2e76030) at
> usshterminalhelper.pas:282
> #4  0x0042b4df in TTERMINALFORM__RUN (this=0x2326c0) at
> uterminalform.pas:163
> #5  0x00421307 in TFRMMAIN__BTNCONNECTTO1CLICK (SENDER=0x1c6820,
> this=0x1cf010) at umain.pas:614
> #6  0x004c09f4 in TCONTROL__CLICK (this=0x1c6820) at control.inc:2227
> #7  0x005033cf in TBUTTONCONTROL__CLICK (this=0x1c6820) at
> buttoncontrol.inc:72
> #8  0x00503895 in TCUSTOMBUTTON__CLICK (this=0x1c6820) at buttons.inc:164
> #9  0x00503df1 in TBUTTON__CLICK (this=0x1c6820) at buttons.inc:331
> #10 0x0050326a in TBUTTONCONTROL__WMDEFAULTCLICKED (MESSAGE={MSG = 66567,
> WPARAM = 1995015919, LPARAM = 197548, RESULT = 0, WPARAMLO = 34543,
> WPARAMHI = 30441, LPARAMLO = 940, LPARAMHI = 3, RESULTLO = 0, RESULTHI =
> 0}, this=0x1c6820) at buttoncontrol.inc:26
> #11 0x0040a549 in SYSTEM_TOBJECT_$__DISPATCH$formal ()
> #12 0x00503250 in TBUTTONCONTROL__ISCHECKEDSTORED (this=0x20af6fc) at
> buttoncontrol.inc:22
> #13 0x004b7522 in TWINCONTROL__WNDPROC (MESSAGE={MSG = 66567, WPARAM =
> 1995015919, LPARAM = 197548, RESULT = 0, WPARAMLO = 34543, WPARAMHI =
> 30441, LPARAMLO = 940, LPARAMHI = 3, RESULTLO = 0, RESULTHI = 0},
> this=0x1c6820) at wincontrol.inc:4920
> #14 0x005253c7 in DELIVERMESSAGE (TARGET=0x1c6820, AMESSAGE=void) at
> lclmessageglue.pas:111
> #15 0x004d7671 in WINDOWPROC (WINDOW=918004, MSG=273, WPARAM=26656,
> LPARAM=197548) at win32callback.inc:2574
> #16 0x00518f81 in PAGEWINDOWPROC (WINDOW=918004, MSG=273, WPARAM=26656,
> LPARAM=197548) at win32wsextctrls.pp:277
> #17 0x76e986ef in USER32!IsWindowVisible () from
> C:\Windows\system32\user32.dll
> #18 0x000e01f4 in ?? ()
> #19 0x00000111 in ?? ()
> #20 0x00006820 in ?? ()
> #21 0x000303ac in ?? ()
> #22 0x00000111 in ?? ()
> #23 0xdcbaabcd in ?? ()
> #24 0x00000000 in ?? ()
> (gdb)
> 
> This seg fault occurs while doing an SCP copy.
> 
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to thread 1004.0x400]
> 0x61ad321a in ssh_log () from H:\freepascal\RAT\Work\trash\libssh.dll
> (gdb) backtrace
> #0  0x61ad321a in ssh_log () from H:\freepascal\RAT\Work\trash\libssh.dll
> #1  0x61ad8f9c in ssh_handle_packets () from
> H:\freepascal\RAT\Work\trash\libssh.dll
> #2  0x61ac5177 in channel_poll () from
> H:\freepascal\RAT\Work\trash\libssh.dll
> #3  0x61ad9bf4 in ssh_scp_write () from
> H:\freepascal\RAT\Work\trash\libssh.dll
> #4  0x005525a8 in TMYSSHTHREAD__SCPCOPYREMOTEFILE (SESSION=0x47d1c08,
> REMOTEFILE=0x2e75738 "/media/live/datatest.txt", LOCALFILE=0x1003d0
> "H:\\freepascal\\RAT\\Work\\datatest.txt", MODE=0, FILESTR=0x0,
> INTERNALERRS=0x100448, this=0x2dcba30) at usshthread.pas:695
> #5  0x00551544 in TMYSSHTHREAD__EXECUTE (this=0x2dcba30) at
> usshthread.pas:371
> #6  0x00435f2b in CLASSES_THREADPROC$POINTER$$LONGINT ()
> #7  0x0040df79 in SYSTEM_THREADMAIN$POINTER$$LONGINT ()
> #8  0x76c51194 in KERNEL32!AcquireSRWLockExclusive () from
> C:\Windows\system32\kernel32.dll
> #9  0x779db3f5 in ntdll!RtlInsertElementGenericTableAvl () from
> C:\Windows\system32\ntdll.dll
> #10 0x779db3c8 in ntdll!RtlInsertElementGenericTableAvl () from
> C:\Windows\system32\ntdll.dll
> #11 0x00000000 in ?? ()
> (gdb)
> 
> Has anybody found any similar issues under Windows 7?
> 
> I am new to gdb, is there something I can to to provide more information
> that may help in fixing this?
> 
> Thanks for the help.