[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] socket.c: fixed uninitialized fd->revents member in ssh_socket_poll() function


Hi Aris,

How about this patch? Not sure if you will release 0.4.7 but if yes, please include this one. Thanks!

Vic

On 10/22/2010 10:50 PM, Aris Adamantiadis wrote:
Hi Vic,

It just took me 10 minutes to understand how setting revent was going to
change something, but I noticed that poll was possible to bypass if
fd->events was zero.

I'm commiting it asap.

Aris

Le 22/10/10 13:59, Vic Lee a écrit :
Hi,

The attached patch is simple and self-explained. It applies to v0-4 branch.

Ths issue was actually quite serious. Intermittently it caused
channel_select() enter in an infinite loop, took 100% CPU and never return.

Vic







Archive administrator: postmaster@lists.cynapses.org