Re: libssh 0.4.7 vs compression

[Aris Adamantiadis <aris@xxxxxxxxxxxx>]

Good :)
Then I think we can release 0.4.8, we were waiting for your feedback
before doing it.

Thanks,

Aris

Le 08/01/11 20:34, Mark Riordan a écrit :
> Never mind - it was a build error.
> 
> Originally I didn't think a problem like this could be caused by a 
> build error, but I was wrong.  
> I had troubles getting CMake to find ZLIB on Windows, even when I
> (allegedly) included the correct zlib paths in FindZLIB.cmake.
> I ended up hard-coding some settings in FindZLIB.cmake, and the
> resulting DLL did not include support for zlib.
> Apparently, however, it did negotiate zlib support, thereby setting
> up the failure I observed.
> 
> On Linux, FindZLIB.cmake did work correctly, and the resulting
> libssh.so did work OK with compression.
> 
> Sorry for the false alarm!
> 
> /mrr
> 
>>> I compared Wireshark traces between the two versions and the only
>>> significant difference I can see (before the server sends a FIN)
>>> is that with 0.4.7, both the client and server send New Keys requests,
>>> whereas with 0.4.6, only the server does.
>>>
>>> Before I pursue this further, I'd like to know whether anyone else
>>> has tested 0.4.7 with compression.
> andreas:
>> Hi Mark,
>>
>> could you do a git bisect to find the culprit?
>>
>> git clone git://git.libssh.org/projects/libssh.git
>> cd libssh
>> git checkout -b v0-4 origin/v0-4
>>
>> git bisect start
>> git bisect bad
>> git bisect good release-0-4-7
>>
>> <build libssh and test>
>>
>> If it works: git bisect good
>> If it fails: git bisect bad
>>
>> It shows you the patch which broke it in ~5 steps.
>>
>> http://book.git-scm.com/5_finding_issues_-_git_bisect.html
> 
> 
> 
>