Re: [PATCH] don't use regexp in commit.c

["Bernhard R. Link" <brlink@xxxxxxxxxx>]

* Aris Adamantiadis <aris@xxxxxxxxxxxx> [110212 12:32]:
> Thanks for you feedback. I have a few questions about your patch ; You
> enumerate a good list of bugs,but why remove the broken code when you
> can fix it ?

Well, the functionality can be implemented in 16 lines of code and is
most likely even faster than goin with a regexp. So why use a regexp
with all those problems involved if the functionality can be implemented
natively reducing the total number of lines needed?

> Did you run into bug caused by it ?

Not including "config.h" before the other headers means any defines
needed by libc to get the requested set of functions. With glibc the
portable set of functions src/connect.c uses will most likely be
available without any of those, but I would not bet that every system
does so.

> ssh_init() call may be indeed omitted by caller, but if you look it's
> the first function being called by ssh_connect.

Ok, I missed this. So one bug less fixed by this.

	Bernhard R. Link