[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [SCM] libssh shared repository - branch v0-5 updated, Oliver Stöneberg
[Thread Prev] | [Thread Next]
- Subject: Re: [SCM] libssh shared repository - branch v0-5 updated, Oliver Stöneberg
- From: "Oliver Stöneberg" <oliverst@xxxxxxxxx>
- Reply-to: libssh@xxxxxxxxxx
- Reply-to: oliverst@xxxxxxxxx
- Date: Tue, 12 Apr 2011 08:41:57 +0200
- To: libssh@xxxxxxxxxx
> * libssh git version control <git@xxxxxxxxxx> [110411 11:19]:
> > diff --git a/src/server.c b/src/server.c
> > index cb29d24..c86c2f4 100644
> > --- a/src/server.c
> > +++ b/src/server.c
> > @@ -104,7 +104,7 @@ static int server_set_kex(ssh_session session) {
> > }
> > }
> >
> > - server->methods = malloc(10 * sizeof(char **));
> > + server->methods = (char **) malloc(10 * sizeof(char **));
> > if (server->methods == NULL) {
> > return -1;
> > }
>
> While I personally have a strong distaste against making code harder to
> read by doing unecessary casts, it may sometimes have the advantage
> of making errors easier to find, like in this example. ;->
>
> Bernhard R. Link
>
I came across this when using VS2010. Strangely it only happens when
you open the file and the IntelliSense kicks in. I found the "strlen"
thing in the same commit more disturbing.
| Re: [SCM] libssh shared repository - branch v0-5 updated, Oliver Stöneberg | "Bernhard R. Link" <brlink@xxxxxxxxxx> |