Re: [PATCH] pki_crypto: pad RSA signature blobs

[Andreas Schneider <asn@xxxxxxxxxxxxxx>]

On Monday 20 January 2014 20:46:51 Jon Simons wrote:
> On 1/20/14, 1:26 AM, Aris Adamantiadis wrote:
> > Could you just tweak your patch to remove the NULL tests ?
> > ssh_string_data is guaranteed to return non-NULL by construction. With
> > this you can also remove the paderrout: label.
> 
> On 1/20/14, 1:28 AM, Andreas Schneider wrote:
> > Instead of memset(), please use the BURN_BUFFER() macro. It ensures that
> > the compiler doesn't optimize away the memset().
> 
> Thanks, Aris and Andreas for reviewing the change.  I've
> attached an updated patch which applies both suggestions.
> 

Could you also fix pki_gcrypt.c if it is needed?


	-- andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
www.cryptomilk.org                asn@xxxxxxxxxxxxxx