Re: [PATCH v2 0/2] Stop using CMAKE_HAVE_THREADS_LIBRARY in the build system

[Aris Adamantiadis <aris@xxxxxxxxxxxx>]

Hi Raphael,

I noticed your patch breaks compilation on macosx:

4e04ec8bf57bdb27ceb84867e04105b2820d3e1f is the first bad commit
Author: Raphael Kubo da Costa <rakuco@xxxxxxxxxxx>
Date:   Mon Feb 3 12:58:37 2014 +0200
    threads: Be less strict when deciding whether to build
libssh_threads.   
(according to git bisect)

Here is my output:
[ 84%] Built target torture
/Applications/Xcode.app/Contents/Developer/usr/bin/make -f
tests/unittests/CMakeFiles/torture_buffer.dir/build.make
tests/unittests/CMakeFiles/torture_buffer.dir/depend
cd /Users/aris/Documents/workspace/libssh/build &&
/usr/local/Cellar/cmake/2.8.12.1/bin/cmake -E cmake_depends "Unix
Makefiles" /Users/aris/Documents/workspace/libssh
/Users/aris/Documents/workspace/libssh/tests/unittests
/Users/aris/Documents/workspace/libssh/build
/Users/aris/Documents/workspace/libssh/build/tests/unittests
/Users/aris/Documents/workspace/libssh/build/tests/unittests/CMakeFiles/torture_buffer.dir/DependInfo.cmake
--color=
/Applications/Xcode.app/Contents/Developer/usr/bin/make -f
tests/unittests/CMakeFiles/torture_buffer.dir/build.make
tests/unittests/CMakeFiles/torture_buffer.dir/build
Linking C executable torture_buffer
cd /Users/aris/Documents/workspace/libssh/build/tests/unittests &&
/usr/local/Cellar/cmake/2.8.12.1/bin/cmake -E cmake_link_script
CMakeFiles/torture_buffer.dir/link.txt --verbose=1
/usr/bin/cc   -std=gnu99 -pedantic -pedantic-errors -Wall -Wextra
-Wshadow -Wmissing-prototypes -Wdeclaration-after-statement -Wunused
-Wfloat-equal -Wpointer-arith -Wwrite-strings -Wformat-security
-Wmissing-format-attribute -fPIC -fstack-protector
-Wno-deprecated-declarations -Wl,-search_paths_first
-Wl,-headerpad_max_install_names  
CMakeFiles/torture_buffer.dir/torture_buffer.c.o  -o torture_buffer 
../libtorture.a /usr/local/lib/libcmocka.dylib ../../src/libssh.a
-lssh_threads_static ../../src/libssh.4.3.0.dylib /usr/lib/libssl.dylib
/usr/lib/libcrypto.dylib /usr/lib/libz.dylib /usr/lib/libssl.dylib
/usr/lib/libcrypto.dylib /usr/lib/libz.dylib /usr/local/lib/libargp.a
ld: library not found for -lssh_threads_static
clang: error: linker command failed with exit code 1 (use -v to see
invocation)
make[2]: *** [tests/unittests/torture_buffer] Error 1
make[1]: *** [tests/unittests/CMakeFiles/torture_buffer.dir/all] Error 2
make: *** [all] Error 2

Thanks for investigating.
Aris

Le 3/02/14 11:58, Raphael Kubo da Costa a écrit :
> Sorry that it took so long to get back to this patch series.
>
> Patch 1 is exactly the same, and patch 2 has been reworked to address
> Andreas' comments: it is much shorter, and only changes the
> CMAKE_HAVE_THREADS_LIBRARY check to less strict one.
>
> As I mention in the commit message, it is important to notice that if one is
> building libssh on some exotic platform that does not have pthreads the
> configuration will fail because CMake will try to create a libssh_threads
> target but won't have any source files to use (this is intended from what I
> could understand from our previous thread).
>
> Cheers.
>
>