[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/2] packet_crypt: Make packet_{en,de}crypt fail consistently on len == 0

On Thursday 06 February 2014 10:26:20 Alan Dunn wrote:
> Doesn't assert only take action when NDEBUG is undefined?  That means
> if this error occurs in a release version, where I believe cmake will
> define NDEBUG, then without the check we might crash with the
> potentially difficult to understand "Decrypt error" (which was
> actually how this whole thing started for me).  Unless we want some
> other version of assert.

The thing is these function should never been called if len is 0. It is a bug 
if we do so.

The assert should be enough that if someone has an error he can enable 
debugging and will find out why.

	-- andreas

Andreas Schneider                   GPG-ID: CC014E3D
www.cryptomilk.org                asn@xxxxxxxxxxxxxx

Archive administrator: postmaster@lists.cynapses.org