[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pki crypto: pki_key_ecdsa_name


On Thursday 27 March 2014 10:31:51 Andreas Schneider wrote:
> On Wednesday 19 March 2014 19:52:20 Jon Simons wrote:
> > Hi,
> 
> Hi Jon,
> 
> > Attached is a patch for a getter to retrieve the "ecdsa-sha2-nistpNNN"
> > name
> > of ECDSA keys, beyond just "ssh-ecdsa" made available with
> > 'ssh_key_type_to_char'.
> 
> I'm going trough your patches add them. Thanks a lot!
> 
> 
> If we add new functions especially to pki which we can easily test with unit
> tests I would like to see a test for it!
> 
> Could you create a (several) test case(s) for this?
> 

Oh, I can't add the patch cause it misses Doxygen documentation. Could you 
please add it and resubmit?

 
Thanks,
 
 	-- andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
www.cryptomilk.org                asn@xxxxxxxxxxxxxx


References:
[PATCH] pki crypto: pki_key_ecdsa_nameJon Simons <jon@xxxxxxxxxxxxx>
Re: [PATCH] pki crypto: pki_key_ecdsa_nameAndreas Schneider <asn@xxxxxxxxxxxxxx>
Archive administrator: postmaster@lists.cynapses.org