Re: Support for SHA2 HMAC algorithms

[Dirkjan Bussink <d.bussink@xxxxxxxxx>]

On 13 Apr 2014, at 17:08, Aris Adamantiadis <aris@xxxxxxxxxxxx> wrote:

> Thanks a lot for your contribution, that's going to be very useful. Just
> a little remark:
> +unsigned char *packet_encrypt(ssh_session session, void *data, uint32_t
> len, enum ssh_hmac_e type) {
> Would it be possible to remove the "type" parameter and have
> packet_encrypt() function figure out by itself the type of hmac to use ?

I’ve updated the patch with this change.

> I also think the hmac code could win at being a little more OO-styled
> like we do for the ciphers (with function pointers instead of switch
> statements). If we could get rid of our horrible
> MD5()/SHA1()/SHA256()/... wrappers by using only EVP functions, it would
> help (but probably out of scope of your patch).

I think refactoring all this is out of scope for this patch. I’d rather not do a major restructuring like this as part of a first contribution, I’d prefer that this would be done in a separate step then.

Regards,

Dirkjan

Attachment: 0001-Add-support-for-SHA2-algorithms.patch
Description: Binary data