[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/4] messages: Add missing ntohl on X11 request screen number


BUG: https://red.libssh.org/issues/160

Signed-off-by: Alan Dunn <amdunn@xxxxxxxxx>
---
 src/messages.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/messages.c b/src/messages.c
index e7bf39f..d0a35f4 100644
--- a/src/messages.c
+++ b/src/messages.c
@@ -1469,6 +1469,7 @@ int ssh_message_handle_channel_request(ssh_session session, ssh_channel channel,
   if (strcmp(request, "x11-req") == 0) {
     ssh_string auth_protocol = NULL;
     ssh_string auth_cookie = NULL;
+    uint32_t screen_number;
 
     buffer_get_u8(packet, &msg->channel_request.x11_single_connection);
 
@@ -1496,7 +1497,8 @@ int ssh_message_handle_channel_request(ssh_session session, ssh_channel channel,
     ssh_string_free(auth_protocol);
     ssh_string_free(auth_cookie);
 
-    buffer_get_u32(packet, &msg->channel_request.x11_screen_number);
+    buffer_get_u32(packet, &screen_number);
+    msg->channel_request.x11_screen_number = ntohl(screen_number);
 
     goto end;
   }
-- 
1.7.9.5


References:
[PATCH 0/4] Fix incorrectly passed X11 request screen numberAlan Dunn <amdunn@xxxxxxxxx>
Archive administrator: postmaster@lists.cynapses.org