ssh1 pty: wrong request state

[Yanis Kurganov <YKurganov@xxxxxxxxxxxxxx>]

I found some errors in ssh1 channel code.

SSH library: 0.6.3 (c) 2003-2014 Aris Adamantiadis, Andreas Schneider, and libssh contributors. Distributed under the LG
PL, please refer to COPYING file for information about your rights
SSH message: ssh_connect: libssh 0.6.3 (c) 2003-2014 Aris Adamantiadis, Andreas Schneider, and libssh contributors. Dist
ributed under the LGPL, please refer to COPYING file for information about your rights, using threading threads_noop
SSH message: getai: host <hidden> matches an IP address
SSH message: ssh_socket_connect: Nonblocking connection socket: 292
SSH message: ssh_connect: Socket connecting, now waiting for the callbacks to work
SSH message: ssh_connect: ssh_connect: Actual timeout : 10000
SSH message: ssh_socket_pollcallback: Received POLLOUT in connecting state
SSH message: socket_callback_connected: Socket connection callback: 1 (0)
SSH message: callback_receive_banner: Received banner: SSH-1.5-OpenSSH_3.8.1p1 Debian-8.sarge.4
SSH message: ssh_client_connection_callback: SSH server banner: SSH-1.5-OpenSSH_3.8.1p1 Debian-8.sarge.4
SSH message: ssh_analyze_banner: Analyzing banner: SSH-1.5-OpenSSH_3.8.1p1 Debian-8.sarge.4
SSH message: ssh_analyze_banner: We are talking to an OpenSSH client version: 3.8 (30800)
SSH message: ssh_socket_unbuffered_write: Enabling POLLOUT for socket
SSH message: ssh_packet_socket_callback1: Reading a 267 bytes packet
SSH message: ssh_packet_socket_callback1: 5 bytes padding
SSH message: ssh_packet_socket_callback1: The packet is valid
SSH message: ssh_packet_process: Dispatching handler for packet type 2
SSH message: ssh_packet_publickey1: Got a SSH_SMSG_PUBLIC_KEY
SSH message: ssh_packet_publickey1: Server bits: 768; Host bits: 1024; Protocol flags: 00000002; Cipher mask: 00000048;
Auth mask: 0000002c
SSH message: ssh_packet_publickey1: Sending SSH_CMSG_SESSION_KEY
SSH message: ssh_packet_publickey1: 1017 bits, 128 bytes encrypted session
SSH message: packet_send1: Sending a 148 bytes long packet
SSH message: packet_send1: 148 bytes after comp + 4 padding bytes = 148 bytes packet
SSH message: ssh_socket_unbuffered_write: Enabling POLLOUT for socket
SSH message: ssh_packet_socket_callback1: Reading a 5 bytes packet
SSH message: ssh_packet_socket_callback1: 3 bytes padding
SSH message: ssh_packet_socket_callback1: The packet is valid
SSH message: ssh_packet_process: Dispatching handler for packet type 14
SSH message: ssh_connect: ssh_connect: Actual state : 7
SSH version: 1
SSH server banner: SSH-1.5-OpenSSH_3.8.1p1 Debian-8.sarge.4
SSH message: packet_send1: Sending a 15 bytes long packet
SSH message: packet_send1: 15 bytes after comp + 1 padding bytes = 15 bytes packet
SSH message: ssh_socket_unbuffered_write: Enabling POLLOUT for socket
SSH message: ssh_packet_socket_callback1: Reading a 5 bytes packet
SSH message: ssh_packet_socket_callback1: 3 bytes padding
SSH message: ssh_packet_socket_callback1: The packet is valid
SSH message: ssh_packet_process: Dispatching handler for packet type 15
SSH message: wait_auth1_status: Auth state : 3
SSH message: send_username: Password authentication necessary for user vipnet
SSH message: packet_send1: Sending a 17 bytes long packet
SSH message: packet_send1: 17 bytes after comp + 7 padding bytes = 17 bytes packet
SSH message: ssh_socket_unbuffered_write: Enabling POLLOUT for socket
SSH message: ssh_packet_socket_callback1: Reading a 5 bytes packet
SSH message: ssh_packet_socket_callback1: 3 bytes padding
SSH message: ssh_packet_socket_callback1: The packet is valid
SSH message: ssh_packet_process: Dispatching handler for packet type 14
SSH message: wait_auth1_status: Auth state : 2
SSH message: channel_open_session1: Opened a SSH1 channel session
SSH message: channel_request_pty_size1: Wrong request state
Error during connection: ssh_channel_request_pty

Attachment: 0003-pty.patch
Description: 0003-pty.patch