Re: Running 'pkd' in Nightly and Coverage Builds

[Aris Adamantiadis <aris@xxxxxxxxxxxx>]

Le 26/01/15 19:31, Jon Simons a écrit :
>>> Ah, I am confused here: why would we need either cwrap or 'sshd' for
>>> doing
>>> the testing that 'pkd_hello' already does?  'pkd' implements the
>>> server-side half of libssh-based pubkey auth and simple data
>>> transmission.
>>> There shouldn't be any reason to need to use preload-based testing
>>> here or
>>> to deal with any 'sshd', for the codepaths that 'pkd' tests.
>>
>> A ssh server needs to open a port. This port is normally port 22
>> which can
>> only be opened a root. We do not really want to use another port, we
>> can't be
>> sure that this port is in use on a system another developer runs the
>> test.
>
> Hmm, it seems complicated to me to introduce an outside dependency and
> to use
> preloading for this.  I would think that if a unit test can't bind to
> some
> port, it should just error out, ideally with a good error message. 
> I'm not
> sure I understand why we would care about using port 22 for testing.
>
> Thanks for detailing the motivation here.
I agree with Jon. If there's a quickfix to make the test run today by
just setting the port number to 2222, we can already configure the
nightly runs for pkd, and not pressure you to complete your cwrap
integration.

Aris