[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Passphrase not working for ssh_pki_export_privkey_file
[Thread Prev] | [Thread Next]
- Subject: Re: Passphrase not working for ssh_pki_export_privkey_file
- From: Andreas Schneider <asn@xxxxxxxxxxxxxx>
- Reply-to: libssh@xxxxxxxxxx
- Date: Fri, 06 Feb 2015 09:35:56 +0100
- To: libssh@xxxxxxxxxx
On Thursday 05 February 2015 16:21:03 Julian Lunz wrote: > I had time to dig a bit further. > > The function pki_private_key_to_pem in src/pki_crypto.c +554 > is missing a cipher in case of passphrase != NULL. > > ssh-keygen uses AES-128-CBC therefore this is used in the attached > patch. > > Is the mailing list the preferred way for patches or better via Redmine? > Thank you very much for your contribution. It is fine to send patches to the mailing list. However to add the patch to the libssh repository we also need a test for it! Please take a look at tests/unittests/torture_pki.c and add a test. You get the unit tests if you install cmocka [1] and run 'cmake -DUNIT_TESTING=ON ..' Cheers, -- andreas [1] http://cmocka.org
Re: Passphrase not working for ssh_pki_export_privkey_file | Julian Lunz <git@xxxxxxxx> |
Re: Passphrase not working for ssh_pki_export_privkey_file | Julian Lunz <git@xxxxxxxx> |