[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Building as a subproject with CMake add_subdirectory


Hi Douglas,

Thanks for your contribution. I well received the dcoo. The patch looks fine to me but I'll await Andreas' review before merging it in.

Regards,

Aris

Le 08/06/15 10:55, Douglas Heriot a écrit :
Hi,

I’m using libssh in my personal project which also uses the CMake build system. The most convenient way for me to build libssh from source (with custom OS X specific options set) is to use the add_subdirectory CMake command.

The issue is, the libssh CMakeLists.txt files use some variables like CMAKE_SOURCE_DIR which points to the root project, instead of CMAKE_CURRENT_SOURCE_DIR which point to the directory you really want.

I’ve made the few changes required to get this to work. I’d like to contribute this to the project for my own and other’s convenience. I’ve attached a diff to this email, or you can pull the commit from my Github repo https://github.com/DouglasHeriot/libssh/commit/6a055ec6d872b819748f29412f8642be33099389

As this is my first time contributing, I have emailed the Developer’s Certificate of Origin to contributing@xxxxxxxxxx


Regards,
Douglas







References:
Building as a subproject with CMake add_subdirectoryDouglas Heriot <douglas@xxxxxxxxxxxxxxxxx>
Archive administrator: postmaster@lists.cynapses.org