Re: [PATCH] Don't allocate a new identity list in the new session's options.

[Andreas Schneider <asn@xxxxxxxxxxxxxx>]

On Monday 15 June 2015 11:54:20 you wrote:
> Anyone?  Thanks!

I was on vacation, pushed to master and v0-7 branch.

Thanks! 


> On Thu, Jun 4, 2015 at 3:39 PM, Seb Boving <seb@xxxxxxxxxx> wrote:
> > The previous list is not freed. Since the new session just got
> > created, an identity list is already allocated and empty.
> > 
> > Signed-off-by: Sebastien Boving <seb@xxxxxxxxxx>
> > ---
> > 
> >  src/options.c | 6 ------
> >  1 file changed, 6 deletions(-)
> > 
> > diff --git a/src/options.c b/src/options.c
> > index 44b1a88..e715c09 100644
> > --- a/src/options.c
> > +++ b/src/options.c
> > @@ -93,12 +93,6 @@ int ssh_options_copy(ssh_session src, ssh_session
> > *dest) {
> > 
> >      if (src->opts.identity) {
> >      
> >          struct ssh_iterator *it;
> > 
> > -        new->opts.identity = ssh_list_new();
> > -        if (new->opts.identity == NULL) {
> > -            ssh_free(new);
> > -            return -1;
> > -        }
> > -
> > 
> >          it = ssh_list_get_iterator(src->opts.identity);
> >          while (it) {
> >          
> >              char *id;

-- 
Andreas Schneider                   GPG-ID: CC014E3D
www.cryptomilk.org                asn@xxxxxxxxxxxxxx