Re: Flag checking the bad way (+patch)

[Aris Adamantiadis <aris@xxxxxxxxxxxx>]

Using the libc constants was a bad decision to begin with. I think a
better solution would be to either create a new function that takes
dedicated flags (why not the SSH ones directly), or extend the existing
API to support the SSH flags.

Aris

Le 3/08/15 10:28, Brian Kimutai a écrit :
> Hello, I have a similar problem, I'm using libssh 0.6.5 and here's a
> mapping of the constants used with the flag values received by the server
> O_RDONLY - 0x1
> O_APPEND - 0x1
> O_WRONLY - 0x3
> O_CREAT - 0X11
> O_TRUNC - 0X21
>
> I've tried these patches and they don't seem to work :(
>
> On Thu, Jul 30, 2015 at 11:49 AM, Andreas Schneider
> <asn@xxxxxxxxxxxxxx <mailto:asn@xxxxxxxxxxxxxx>> wrote:
>
>     On Wednesday 22 July 2015 15:50:37 Tilo Eckert wrote:
>     > Hi,
>
>     Hi Tilo,
>
>     > Patches for both are attached. Note that I only checked the SFTP
>     module
>     > for flags issues. Someone might want to look for other similar
>     places.
>
>     thank you very much for your patches. I've pushed them upstream.
>
>
>             -- andreas
>
>     --
>     Andreas Schneider                   GPG-ID: CC014E3D
>     www.cryptomilk.org <http://www.cryptomilk.org>               
>     asn@xxxxxxxxxxxxxx <mailto:asn@xxxxxxxxxxxxxx>
>
>
>