Re: [PATCH] socket: ssh_socket_write() should return socket write errors

[Nicolas Viennot <nicolas@xxxxxxxxxxx>]

Hum. Disregard my previous email, I was a bit confused.
Seems the call to nonblocking_flush() is an optimization of some sort.

On Tue, Sep 15, 2015 at 5:46 PM, Nicolas Viennot <nicolas@xxxxxxxxxxx> wrote:
> Signed-off-by: Nicolas Viennot <nicolas@xxxxxxxxxxx>
> ---
>  src/socket.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/socket.c b/src/socket.c
> index 022c9a7..0601beb 100644
> --- a/src/socket.c
> +++ b/src/socket.c
> @@ -619,7 +619,7 @@ int ssh_socket_write(ssh_socket s, const void
> *buffer, int len) {
>        ssh_set_error_oom(s->session);
>        return SSH_ERROR;
>      }
> -    ssh_socket_nonblocking_flush(s);
> +    return ssh_socket_nonblocking_flush(s);
>    }
>
>    return SSH_OK;
> --
> 2.4.2