[PATCH 00/24] Adding namespace, fixing some warnings and exposing some buffer functions

[Fabiano Fidêncio <fidencio@xxxxxxxxxx>]

Fabiano Fidêncio (24):

These first nine patches are basically adding a ssh_ prefix in all non static functions,
avoiding possible clashes when compiling libssh statically.

  cleanup: use ssh_ prefix in the agent (non-static) functions
  cleanup: use ssh_ prefix in the bignum (non-static) functions
  cleanup: use ssh_ prefix in the blf (non-static) functions
  cleanup: use ssh_ prefix in the buffer (non-static) functions
  cleanup: use ssh_ prefix in the channels (non-static) functions
  cleanup: use ssh_ prefix in the dh (non-static) functions
  cleanup: use ssh_ prefix in the kex (non-static) functions
  cleanup: use ssh_ prefix in the gcrypt missing functions
  cleanup: use ssh_ prefix in the packet (non-static) functions

These next two patches are fixing some warnings during compilation.

  pki_gcrypt: Fix warning about not handled values in switch
  tests: Fix warning about expected format for printf

These next two patches are doing cosmetic fixes in ssh_buffer_get_u{8,32}() functions.

  buffer: fix documentation for ssh_buffer_get_u32()
  buffer: cosmetic change in ssh_buffer_get_u8() documentation

These next seven patches are basically adapting ssh_buffer_get() and ssh_buffer_get_len()
to have the same behaviour as ssh_buffer_get_rest() and ssh_buffer_get_rest_len() and then
removing the last two functions and also ssh_buffer_get_begin()

  buffer: rename ssh_buffer_get_rest() to ssh_buffer_get()
  buffer: make ssh_buffer_get_len() call ssh_buffer_get_rest_len()
  pki_gcrypt: adapt to the new behavior of ssh_buffer_get_len()
  buffer: do not use ssh_buffer_get_rest_len()
  buffer: remove ssh_buffer_get_rest_len()
  buffer: use ssh_buffer_get() instead of ssh_buffer_get_begin()
  buffer: remove ssh_buffer_get_begin()

These last 4 patches are exposing the buffer APIs needed for writing an ssh-agent using libssh.

  libssh.h: move LIBSSH_API buffer' functions to libssh.h
  buffer: expose ssh_buffer_reinit()
  buffer: expose ssh_buffer_{add,get}_data()
  buffer: expose ssh_buffer_get()

Changes since v1:
- Added a few forgotten changes to the buffer's patch adding the ssh_ namespace
- Cosmetic fixes in ssh_buffer_getu{8,32}() functions
- Changes on ssh_buffer_get{,_len}(), removing ssh_buffer_get_rest{,_len)() and ssh_buffer_get_begin()
- Expose the buffer APIs needed for writing an ssh-agent using libssh

 examples/sample.c                |   4 +-
 include/libssh/agent.h           |   8 +--
 include/libssh/bignum.h          |   6 +-
 include/libssh/blf.h             |  26 +++----
 include/libssh/buffer.h          |  46 +++++-------
 include/libssh/channels.h        |  12 ++--
 include/libssh/dh.h              |  28 ++++----
 include/libssh/kex.h             |   6 +-
 include/libssh/libgcrypt.h       |   8 +--
 include/libssh/libssh.h          |   8 +++
 include/libssh/packet.h          |  18 ++---
 src/agent.c                      |  40 +++++------
 src/auth.c                       |  22 +++---
 src/auth1.c                      |  12 ++--
 src/bignum.c                     |   6 +-
 src/buffer.c                     | 147 +++++++++++++++------------------------
 src/channels.c                   |  88 +++++++++++------------
 src/channels1.c                  |  66 +++++++++---------
 src/client.c                     |   6 +-
 src/dh.c                         |  92 ++++++++++++------------
 src/external/bcrypt_pbkdf.c      |   4 +-
 src/external/blowfish.c          |  42 +++++------
 src/gcrypt_missing.c             |   4 +-
 src/gssapi.c                     |  34 ++++-----
 src/gzip.c                       |  14 ++--
 src/kex.c                        |  34 ++++-----
 src/kex1.c                       |  36 +++++-----
 src/known_hosts.c                |  22 +++---
 src/legacy.c                     |   2 +-
 src/messages.c                   |  28 ++++----
 src/options.c                    |   2 +-
 src/packet.c                     |  54 +++++++-------
 src/packet1.c                    |  44 ++++++------
 src/packet_cb.c                  |  10 +--
 src/packet_crypt.c               |  12 ++--
 src/pcap.c                       |  44 ++++++------
 src/pki.c                        |  52 +++++++-------
 src/pki_container_openssh.c      |  22 +++---
 src/pki_crypto.c                 |  50 ++++++-------
 src/pki_gcrypt.c                 |  42 +++++------
 src/server.c                     |  50 ++++++-------
 src/session.c                    |   8 +--
 src/sftp.c                       | 130 +++++++++++++++++-----------------
 src/sftpserver.c                 |  48 ++++++-------
 src/socket.c                     |  18 ++---
 tests/benchmarks/bench_scp.c     |   4 +-
 tests/client/torture_auth.c      |   4 +-
 tests/unittests/torture_buffer.c |  70 +++++++++----------
 48 files changed, 747 insertions(+), 786 deletions(-)

-- 
2.4.3