Re: [PATCH 1/5] options: Check if a port has been given

[Andreas Schneider <asn@xxxxxxxxxxxxxx>]

On Monday 21 March 2016 15:16:39 Justus Winter wrote:
> * src/options.c (ssh_options_getopt): Only call 'ssh_options_set' if
> a port has been given.

Hi Justus,

thanks for your patchset. Please use brackets in all statements even for a 
single line.

I think the most prominent issue with missing brackets is Apples 'goto fail'. 
However experience shows that missing brackets lead to errors.

Please also add brackets to the other patches.


Thanks,


	-- andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
www.cryptomilk.org                asn@xxxxxxxxxxxxxx