[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix config file reading

On Sunday, 4 June 2017 11:08:02 CEST Artyom Poptsov wrote:
> Hello,
> I've found that libssh 0.7.5 fails to read a configuration file with
> 'ssh_options_parse_config' procedure due to a wrong check in
> 'ssh_config_parse_line' procedure: all *unseen* opcodes are effectively
> skipped.  The problem is present on the 'master' branch as well.  To my
> understanding, the problem was introduced in
> '5f202d7ffa48f2ee989e0e6c1e761963c68ab08f' commit.
> I prepared a patch that fixes the aforementioned check.  I did some
> tests with my libssh based project and it seems that the patch works OK
> for me.  Please find the patch attached.

Thanks for your patch!

We really need tests for this code.


Andreas Schneider                   GPG-ID: CC014E3D
www.cryptomilk.org                asn@xxxxxxxxxxxxxx

[PATCH] Fix config file readingArtyom Poptsov <poptsov.artyom@xxxxxxxxx>
Archive administrator: postmaster@lists.cynapses.org