[PATCH 04/11] pki_crypto: annotate BoringSSL incompatibilities

[Jon Simons <jon@xxxxxxxxxxxxx>]

Comments-only change: mark a TODO in each of
the spots that do not build with BoringSSL.

Signed-off-by: Jon Simons <jon@xxxxxxxxxxxxx>
---
 src/pki_crypto.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/pki_crypto.c b/src/pki_crypto.c
index f5e8fb09..e061696d 100644
--- a/src/pki_crypto.c
+++ b/src/pki_crypto.c
@@ -261,7 +261,7 @@ ssh_key pki_key_dup(const ssh_key key, int demote)
             goto fail;
         }
 
-        rc = DSA_set0_pqg(new->dsa, np, nq, ng);
+        rc = DSA_set0_pqg(new->dsa, np, nq, ng); /* TODO: not in BoringSSL */
         if (rc == 0) {
             BN_free(np);
             BN_free(nq);
@@ -275,7 +275,7 @@ ssh_key pki_key_dup(const ssh_key key, int demote)
             goto fail;
         }
 
-        rc = DSA_set0_key(new->dsa, npub_key, NULL);
+        rc = DSA_set0_key(new->dsa, npub_key, NULL); /* TODO: not in BoringSSL */
         if (rc == 0) {
             goto fail;
         }
@@ -322,7 +322,7 @@ ssh_key pki_key_dup(const ssh_key key, int demote)
             goto fail;
         }
 
-        rc = RSA_set0_key(new->rsa, nn, ne, NULL);
+        rc = RSA_set0_key(new->rsa, nn, ne, NULL); /* TODO: not in BoringSSL */
         if (rc == 0) {
             BN_free(nn);
             BN_free(ne);
@@ -357,7 +357,7 @@ ssh_key pki_key_dup(const ssh_key key, int demote)
                     goto fail;
                 }
 
-                rc = RSA_set0_factors(new->rsa, np, nq);
+                rc = RSA_set0_factors(new->rsa, np, nq); /* TODO: not in BoringSSL */
                 if (rc == 0) {
                     BN_free(np);
                     BN_free(nq);
@@ -377,7 +377,7 @@ ssh_key pki_key_dup(const ssh_key key, int demote)
                     goto fail;
                 }
 
-                rc =  RSA_set0_crt_params(new->rsa, ndmp1, ndmq1, niqmp);
+                rc =  RSA_set0_crt_params(new->rsa, ndmp1, ndmq1, niqmp); /* TODO: not in BoringSSL */
                 if (rc == 0) {
                     BN_free(ndmp1);
                     BN_free(ndmq1);
@@ -1250,7 +1250,7 @@ static ssh_string pki_dsa_signature_to_blob(const ssh_signature sig)
     ssh_string s;
     int s_len, s_offset_in, s_offset_out;
 
-    DSA_SIG_get0(sig->dsa_sig, &pr, &ps);
+    DSA_SIG_get0(sig->dsa_sig, &pr, &ps); /* TODO: not in BoringSSL */
     r = ssh_make_bignum_string((BIGNUM *)pr);
     if (r == NULL) {
         return NULL;
@@ -1316,7 +1316,7 @@ ssh_string pki_signature_to_blob(const ssh_signature sig)
                 return NULL;
             }
 
-            ECDSA_SIG_get0(sig->ecdsa_sig, &pr, &ps);
+            ECDSA_SIG_get0(sig->ecdsa_sig, &pr, &ps); /* TODO: not in BoringSSL */
             r = ssh_make_bignum_string((BIGNUM *)pr);
             if (r == NULL) {
                 ssh_buffer_free(b);
@@ -1500,7 +1500,7 @@ ssh_signature pki_signature_from_blob(const ssh_key pubkey,
                 return NULL;
             }
 
-            rc = DSA_SIG_set0(sig->dsa_sig, pr, ps);
+            rc = DSA_SIG_set0(sig->dsa_sig, pr, ps); /* TODO: not in BoringSSL */
             if (rc == 0) {
                 ssh_signature_free(sig);
                 return NULL;
@@ -1578,7 +1578,7 @@ ssh_signature pki_signature_from_blob(const ssh_key pubkey,
                     return NULL;
                 }
 
-                rc = ECDSA_SIG_set0(sig->ecdsa_sig, pr, ps);
+                rc = ECDSA_SIG_set0(sig->ecdsa_sig, pr, ps); /* TODO: not in BoringSSL */
                 if (rc == 0) {
                     ssh_signature_free(sig);
                     return NULL;
-- 
2.14.1