Re: Problem building 0.8.0 with VS 2015

[Andreas Schneider <asn@xxxxxxxxxxxxxx>]

On Friday, 10 August 2018 17:42:55 CEST John Dunn wrote:
> Hello

Hi John,

> On Win32, defining as
> 
> 	#define CONSTRUCTOR_ATTRIBUTE
> 	#define DESTRUCTOR_ATTRIBUTE
> 
> Appears to fix the problem. I've attached a patch that addresses this issue.
> Please let me know if there is an issue with my change or if the patch is
> incorrectly formatted.

thank you very much for your contribution. You're correct that we should not 
define this on Windows. However I've fixed it differently by actually checking 
if the compiler supports the flag.

I've also learned about DllMain() however I haven't tested it. Could you check 
if it works?

The code is here:
https://git.libssh.org/users/asn/libssh.git/log/?h=master-constructor


I will release libssh 0.8.1 soon.


Thanks!


	Andreas

-- 
Andreas Schneider                 asn@xxxxxxxxxxxxxx
GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D