Re: (Client side) RSA signatures with SHA2 (RFC 8332 and RFC 8308)

[Andreas Schneider <asn@xxxxxxxxxxxxxx>]

On Friday, 31 August 2018 10:49:03 CEST Jakub Jelen wrote:
> Hello,

Hi Jakub,
 
> based on our discussion yesterday, I rewrote the patches not to define
> new key types, and hide the signature hash inside of signature
> structure. This makes the changes a bit bigger, but they will hopefully
> be more acceptable.

the code looks really good now! Well done.

> The current patch set is available here and in attachment.
> 
> https://gitlab.com/jjelen/libssh-mirror/tree/rsa-sha2-v2

I just have some minor things with should be fixed. I've commented the code at 
gitlab.



	Andreas

-- 
Andreas Schneider                 asn@xxxxxxxxxxxxxx
GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D