[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bugs when using rsa-sha2 (+patches)
[Thread Prev] | [Thread Next]
- Subject: Re: Bugs when using rsa-sha2 (+patches)
- From: Andreas Schneider <asn@xxxxxxxxxxxxxx>
- Reply-to: libssh@xxxxxxxxxx
- Date: Thu, 29 Nov 2018 08:49:59 +0100
- To: libssh@xxxxxxxxxx
- Cc: Tilo Eckert <tilo.eckert@xxxxxxx>
On Tuesday, 27 November 2018 17:56:23 CET Tilo Eckert wrote: > Hello Jakub, Hi Tilo, > the solution looks fine to me except for the assignment > sig->type_c = pubkey->type_c The type_c is an internal shortcut to avoid conversions and allocations, should it should be kept a `const char *` only pointing to text data. It should not be allocated. The patch is fine, it should should not call strdup(). Andreas -- Andreas Schneider asn@xxxxxxxxxxxxxx GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D
Bugs when using rsa-sha2 (+patches) | Tilo Eckert <tilo.eckert@xxxxxxx> |
Re: Bugs when using rsa-sha2 (+patches) | Jakub Jelen <jjelen@xxxxxxxxxx> |
Re: Bugs when using rsa-sha2 (+patches) | Tilo Eckert <tilo.eckert@xxxxxxx> |