Re: ssh_options_set value param outdated

[Andreas Schneider <asn@xxxxxxxxxxxxxx>]

On Thursday, 24 January 2019 13:45:49 CET g4-lisz@xxxxxxxxxxxx wrote:
> On 20.01.19 14:41, g4-lisz@xxxxxxxxxxxx wrote:
> > Hi there
> > 
> > In options.c for function ssh_options_set(), the value @param annotation
> > is outdated:
> > 
> >  *              - SSH_OPTIONS_LOG_CALLBACK:
> >  *                Set a callback to use your own logging function
> >  *                (function pointer).
> >  *
> >  *              - SSH_OPTIONS_LOG_USERDATA:
> >  *                Set the user data passed to the logging function
> >  *                (generic pointer).
> > 
> > Logging callback and logging useradata is outdated and is not treated
> > anywhere in options.c
> > 
> > But it still get's its way into the documentation, so this is confusing.
> 
> Ok... Should I submit a patch? But I'm really new to Git, and things are
> quite confusing for a SVN user.

Yes, please create a patch. The way it works is normally:

git checkout -b myfix origin/master
<do changes>
git commit -a -s
git format-patch -1

Send the created patch as an attachement to the mailinglist :-)


	Andreas