Re: Reading multiple channels under the same session

[Alberto Garcia <agarciaillera@xxxxxxxxx>]

Hi,

what about waiting to call ssh_event_remove_fd()
until my_channel_close_function() is reached?

On Wed, Jan 30, 2019 at 1:48 PM Alberto Garcia <agarciaillera@xxxxxxxxx>
wrote:

> Hi,
> So it is not something specific from Windows that needs to be changed
> right?
>
> Good gob finding the root cause! :applause:
>
> On Wed, Jan 30, 2019 at 1:40 PM <g4-lisz@xxxxxxxxxxxx> wrote:
>
>> I have found the issue. And I have an idea how to solve it... But it
>> needs a bit of a redesign of the whole channel / data handling.
>>
>> The problem is that I call  ssh_event_remove_fd() in the callback
>> function, which in turn de-registers this very callback function...
>>
>> This could have worked in a single thread, but there's some channel
>> flusing involved, which calls the channel callback function again... And so
>> on.
>>
>> What I don't understand is why it did work at all for a certain time ;-)
>>
>> Till
>> On 30.01.19 20:25, g4-lisz@xxxxxxxxxxxx wrote:
>>
>> I think we face two different problems: One is related to my shaky code
>> only. But the second one could be indeed related to polling and blocking on
>> Windows.
>>
>> Till
>> On 30.01.19 19:18, Alberto Garcia wrote:
>>
>> We think it is because of a problem with libssh. Andreas maybe you can
>> bring some light to spot the bug?
>>
>> On Wed, Jan 30, 2019, 6:19 AM <g4-lisz@xxxxxxxxxxxx wrote:
>>
>>> On 30.01.19 09:27, Andreas Schneider wrote:
>>> > On Friday, January 25, 2019 3:26:10 PM CET g4-lisz@xxxxxxxxxxxx wrote:
>>> >> On 24.01.19 22:09, Alberto Garcia wrote:
>>> >>> Can you please post the link to the mentioned code?
>>> >>> Thanks
>>> >> Here you go.
>>> > Hi Till,
>>> >
>>> > if you send it as a patch I'm happy to add it to the examples dir.
>>> Even if the
>>> > code isn't the cleanest we can still fix that later. Our current
>>> examples are
>>> > also not the best ;-)
>>>
>>> Hi Andreas,
>>>
>>> Alberto found a test case where it always crashes... I at least have to
>>> fix this before we should conisder it as an example at all... Maybe as a
>>> bad example? ;-)
>>>
>>> Cheers,
>>> Till
>>>
>>>
>>>
>
> --
> Alberto García Illera
>
> GPG Public Key <https://goo.gl/yshdwh>
>


-- 
Alberto García Illera

GPG Public Key <https://goo.gl/yshdwh>