[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 0/2] kex: fix RFC8332 RSA extension selection bug
[Thread Prev] | [Thread Next]
- Subject: [PATCH v2 0/2] kex: fix RFC8332 RSA extension selection bug
- From: Jon Simons <jon@xxxxxxxxxxxxx>
- Reply-to: libssh@xxxxxxxxxx
- Date: Wed, 6 Feb 2019 12:39:18 -0500
- To: libssh@xxxxxxxxxx
- Cc: jjelen@xxxxxxxxxx, Jon Simons <jon@xxxxxxxxxxxxx>
Changes since first version: I've fixed the `strcmp` comparison style to fit better with existing code, per review from Jakub. Included here is an update to the pkd tests to reproduce a bug in RFC8332 RSA extension selection, as well as a fix which makes the test pass. When libssh server is provided "rsa-sha2-256,rsa-sha2-512" by the client for host key algorithms, it will unconditionally reply using the rsa-sha2-512 variant. But, the server should respect the client's preference in this case and use rsa-sha2-256. Jon Simons (2): tests/pkd: repro rsa-sha2-{256,512} negotiation bug kex: honor client preference for rsa-sha2-{256,512} host key algorithms src/kex.c | 24 ++++++++++++++++++++++++ tests/pkd/pkd_client.h | 15 +++++++++------ tests/pkd/pkd_hello.c | 8 ++++++++ 3 files changed, 41 insertions(+), 6 deletions(-) -- 2.19.1.593.gc670b1f
[PATCH v2 1/2] tests/pkd: repro rsa-sha2-{256,512} negotiation bug | Jon Simons <jon@xxxxxxxxxxxxx> |
[PATCH v2 2/2] kex: honor client preference for rsa-sha2-{256,512} host key algorithms | Jon Simons <jon@xxxxxxxxxxxxx> |
Re: [PATCH v2 0/2] kex: fix RFC8332 RSA extension selection bug | Jakub Jelen <jjelen@xxxxxxxxxx> |