[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: auth_fn segfaults when reading encrypted private key in new openssh format


On Tue, 2019-03-26 at 13:11 +0100, Jeroen Ooms wrote:
> On Tue, Mar 26, 2019 at 10:40 AM Jakub Jelen <jjelen@xxxxxxxxxx>
> wrote:
> 
> OK maybe you are right. I was ignoring the 'len' parameter in the
> my_auth_callback (are these parameters documented somewhere?). The
> callback had a line like this:
> 
>   strncpy(buf, password, 1024);
> 
> So I assumed there would be at least 1024 bytes in the buffer. But it
> seems that for the new openssh keys, the target buffer for the
> passphrase is only 128 bytes.

Probably only in the header file:

https://git.libssh.org/projects/libssh.git/tree/include/libssh/libssh.h#n625

Regards,
-- 
Jakub Jelen
Senior Software Engineer
Security Technologies
Red Hat, Inc.


Archive administrator: postmaster@lists.cynapses.org