Re: Libssh on Windows 10

["Kennedy, Marcus A." <Marcus.Kennedy@xxxxxxxxxx>]

Anderson,

Thanks!  That seems to have fixed it.  I'll let you know if I find anything else.

Strange that Windows 7 didn't catch this bug, but Windows 10 did.

Andy

-----Original Message-----
From: Anderson Sasaki <ansasaki@xxxxxxxxxx> 
Sent: Thursday, October 3, 2019 12:22 PM
To: libssh@xxxxxxxxxx
Subject: [EXTERNAL] Re: Libssh on Windows 10

Hello,

> So, I connect to the app with the VS debugger and find:
> file: pki_crypto.c:
> function:  pki_signature_from_ecdsa_blob()
> line: (1769) SAFE_FREE(raw_sig_data);
> is what VS claims generated this error.
> 
> So, upgrading to openssl-1.1.1d didn't help me.  Any other suggestions?
> 
> I'm currently digging into the code, but I’m having issues following it.

This is a bug, thanks for digging. I just proposed a fix for this:

https://gitlab.com/libssh/libssh-mirror/merge_requests/65

Can you check if applying this change makes it to work for you?

Thank you,
Anderson

> 
> Thanks,
> Andy
> 
> From: Kennedy, Marcus A. <Marcus.Kennedy@xxxxxxxxxx>
> Sent: Monday, September 30, 2019 5:08 PM
> To: libssh@xxxxxxxxxx
> Subject: RE: [EXTERNAL] Re: Libssh on Windows 10
> 
> 
> Humph.  I didn't know there was a 1.1.1 ;).
> 
> Didn't occur to me to look for a new version as this configuration worked
> with Windows 7.
> 
> So, thanks for the info.  I'm building it up right now.
> 
> Andy
> 
> From: Franciszek Juras <mailto:franciszekjuras@xxxxxxxxx>
> Sent: Monday, September 30, 2019 4:55 PM
> To: mailto:libssh@xxxxxxxxxx
> Subject: [EXTERNAL] Re: Libssh on Windows 10
> 
> AFAIK libssh 0.9 should be build against openssl 1.1.1
> 
> And openssl 1.0.2 support ends at the end of the year anyway.
> 
> FJ
> pon., 30 wrz 2019, 23:41 użytkownik Kennedy, Marcus A.
> <mailto:Marcus.Kennedy@xxxxxxxxxx> napisał:
> All,
>  
> libssh-0.9.0
> openssl-1.0.2s
>  
> I'm just now digging into this, but I'm getting a "Debug Assertion Failed".
>   Attaching to it with VS 2017 debugger showed me to be in a call to
> SAFE_FREE() deep within a pki_ function.
>  
> While discussing it with someone on my team, it occurred to me that I had
> built both openssl and libssh using a Windows 7 SDK.  I rebuilt just a bit
> ago and am still getting the same results.
>  
> Both libssh and openssl were built using the VS2017 SDK.  The previous
> version I obviously built in Debug mode (as I could step deep into the
> library, but now I cannot -- no idea why, I used the same set of
> instructions I wrote the first time through the build).
>  
> Anyone have an idea where I could begin to trace this down?
>  
> Thanks,
> Andy
>  
>