Re: [PATCH] packet: Change the last argument of ssh_packet_encrypt to uint32_t

[Jakub Jelen <jjelen@xxxxxxxxxx>]

On 5/9/21 4:47 PM, Xiang Xiao wrote:
> to match the implemntation in packet_crypt.c
>
> Signed-off-by: Xiang Xiao <xiaoxiang@xxxxxxxxxx>
> Change-Id: Ib76c3585f67dae22ed0f1dfc10dadcd03c762032
> ---
>   include/libssh/packet.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/libssh/packet.h b/include/libssh/packet.h
> index 8fc7ce42..561bba8e 100644
> --- a/include/libssh/packet.h
> +++ b/include/libssh/packet.h
> @@ -80,7 +80,7 @@ int ssh_packet_decrypt(ssh_session session, uint8_t *destination, uint8_t *sourc
>           size_t start, size_t encrypted_size);
>   unsigned char *ssh_packet_encrypt(ssh_session session,
>                                     void *packet,
> -                                  unsigned int len);
> +                                  uint32_t len);
>   int ssh_packet_hmac_verify(ssh_session session, const void *data, size_t len,
>                              unsigned char *mac, enum ssh_hmac_e type);
>   int ssh_packet_set_newkeys(ssh_session session,

Thank you for the patches. They look fine.

I submitted them as a MR in gitlab with a fix for CI to trigger a CI on 
them:

https://gitlab.com/libssh/libssh-mirror/-/merge_requests/172

Thanks,
--
Jakub Jelen
Senior Software Engineer
Crypto Team, Security Engineering
Red Hat, Inc.