Re: Question on tarball source files

[Jakub Jelen <jjelen@xxxxxxxxxx>]

Sounds like you are using OpenSSL 3.0 built without deprecated API. I
think we did not test this thoroughly as we were encountering some
issues in 0.10 branch when migrating to openssl 3.0 as some of the
operations were not possible back in the time.

But in any case, the libgcrypt-compat should not be built only when
the detected openssl version is < 1.1.1

https://gitlab.com/libssh/libssh-mirror/-/blob/libssh-0.10.5/src/libcrypto-compat.h?ref_type=tags#L10
https://gitlab.com/libssh/libssh-mirror/-/blob/libssh-0.10.5/src/CMakeLists.txt#L259

Can you share the cmake options you are using, output of the cmake run
and `CMakeCache.txt` to verify the openssl version is detected
correctly?

What container image are you using as a base for your build?

Jakub

On Tue, Jun 13, 2023 at 12:36 PM Maher, Katie <katie.maher@xxxxxxx> wrote:
>
> Hi,
>
> Thanks for your response. Below are some of the issues I'm getting. I think it's because its having problems reading the libcrypto-compat.h file
>
> /root/externals/libssh/src/libcrypto-compat.c:107:32: error: unknown type name 'RSA'
>   107 | void RSA_get0_crt_params(const RSA *r,
>       |                                ^~~
> /root/externals/libssh/src/libcrypto-compat.c:108:32: error: unknown type name 'BIGNUM'
>   108 |                          const BIGNUM **dmp1, const BIGNUM **dmq1,
> /root/externals/libssh/src/libcrypto-compat.c:114:18: error: request for member 'dmq1' in something not a structure or union
>   114 |         *dmq1 = r->dmq1;
>       |                  ^~
> /root/externals/libssh/src/libcrypto-compat.c:226:23: error: implicit declaration of function 'OPENSSL_malloc' [-Werror=implicit-function-declaration]
>   226 |     EVP_MD_CTX *ctx = OPENSSL_malloc(sizeof(EVP_MD_CTX));
>       |                       ^~~~~~~~~~~~~~
> /root/externals/libssh/src/libcrypto-compat.c:226:45: error: 'EVP_MD_CTX' undeclared (first use in this function); did you mean 'EVP_MD_CTX_new'?
>   226 |     EVP_MD_CTX *ctx = OPENSSL_malloc(sizeof(EVP_MD_CTX));
>       |                                             ^~~~~~~~~~
>       |                                             EVP_MD_CTX_new
>
>
>
> Kind Regards,
> Katie
>
> -----Original Message-----
> From: Jakub Jelen <jjelen@xxxxxxxxxx>
> Sent: 13 June 2023 09:05
> To: libssh@xxxxxxxxxx
> Subject: Re: Question on tarball source files
>
> Hello,
> the 0.10.5 is the latest version that should work fine with OpenSSL 3.0. There were some changes since then in master but it will take some time before they will be released.
> Can you post the errors you are getting? We are running CI against OpenSSL 3.0 also in the stable-0.10 branches and all looks good:
>
> https://gitlab.com/libssh/libssh-mirror/-/commits/stable-0.10
>
> Regards,
> Jakub
>
> On Mon, Jun 12, 2023 at 5:36 PM Maher, Katie <katie.maher@xxxxxxx> wrote:
> >
> > Hi libssh team,
> >
> >
> >
> > I just wanted to ask a question about the tarballs listed under https://www.libssh.org/files/  . We are building a docker image that uses OpenSSL 3 and are trying to use libssh v. 0.10.5 in it. However, I have been getting many errors coming from the libssh/src/libcrypto-compat.c file. I can see from your gitlab repo that this file was removed since about October of last year, however the tarball source files still have this file. Just wondering where I can get the most up to date tarball source file for v. 0.10.5? Or maybe I am missing something?
> >
> >
> >
> > Thanks in advance! 😊
> >
> >
> >
> > Kind regards,
> >
> > Katie
> >
> >
>
>