Re: Building libssh on Visual Studio 2005

[Aris Adamantiadis <aris@xxxxxxxxxxxx>]

Andreas,

I agree 100% on the principle of asking git patches, but I think we
could give a complete and simple procedure for this. as an example:
1) Checkout the last git on the branch you made you patch on (head or v3-0)
2) Apply your patch or code it
3) git config (your name + email)
4) git add <one of the file for the partial patch>
5) git commit
6) while(still have partial patches) goto 4
7) some complicated git command to create the patch to be applied or
pushing on a remote server

This procedure could be on the libssh website so we don't freak to the
death newcomers frightened by the git tool (like would say obi-wan, As I
was too when younger)

Thanks,

Aris
Andreas Schneider a écrit :
> On Tuesday 07 July 2009 10:39:06 Cyril Russo wrote:
>   
>> Hi,
>>     
>
> Hi Cyril,
>
>   
>>    The attached patch fix the build process on VS2005.
>> You'll still need to hack the cmake stuff, as I don't know enough of
>> cmake to fix this by myself.
>> I've modified the final .vcproj produced by cmake to make it use the
>> included .def file (so ssh.dll actually export symbols).
>>     
>
> thanks for your contribution. I think all you have to do is to add libssh.map 
> in libssh_SRCS in src/CMakeLists.txt. Could you you test this?
>
> If not then add the libssh.def file in the src directory and add it to 
> libssh_SRCS in src/CMakeLists.txt
>
>   
>> The second patch fix the closesocket issue I've forgot in the initial
>> patch, and apply to last git + the first patch.
>> Hope it helps.
>>     
>
> Could you please redo that patches. Please set your name and email in git, 
> see:
>
> http://book.git-scm.com/2_setup_and_initialization.html
>
> Then please create more patches and group them in fixes with better comments 
> and features. This makes it easier to review and easier to debug if something 
> should go wrong.
>
> 'git add -i' and 'git rebase -i' are your friends.
>
> http://book.git-scm.com/4_interactive_adding.html
>
> Thanks,
>
>
> 	-- andreas
>