Re: PATCH & Contribution Signoff: password Protected Server Keys

[Andreas Schneider <asn@xxxxxxxxxxxxxx>]

On Monday 21 October 2013 09:32:37 Aris Adamantiadis wrote:
> Hi Andreas,
> 
> +1 for the naming. What about moving this into the ssh_callback
> structure that is common to ssh client, server and bind ? (along with
> the logging functions). We could name it key_decrypt_callback and use
> the same callback for host keys and user keys.

Hmm, currently we use

session->common.callbacks->auth_function

in ssh_userauth_publickey(). And that's the only user of auth_function.
 
> Aris
> 
> Le 20/10/13 12:54, Andreas Schneider a écrit :
> > On Tuesday 10 September 2013 00:08:45 drbob wrote:
> >> Hi, as this is my first libssh patch,
> >> let me know if you want any tweaks -
> >> or would prefer this done in a different way.
> >> 
> >> It would be great if this could be included before V0.6.0 release.
> >> 
> >> thanks.
> > 
> > I think the name ssh_bind_set_auth_callbacks is not good. Someone might
> > think he has to set the function to authenticate users (password,
> > keyboard- interactive, etc. here).
> > 
> > I would use ssh_bind_set_hostkey_callbacks() or something like that.
> > 
> > 	-- andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
www.cryptomilk.org                asn@xxxxxxxxxxxxxx