[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] Add ssh_get_poll_flags()

On Sat, 2013-11-09 at 12:28 +0100, Andreas Schneider wrote:

> I've added it. Could you please look into extending it and check for data 
> exception 

Hm, you're talking about the "data_except" member of ssh_socket_struct?
From what I can tell that's a flag that gets set if we caught an error,
but (I'd hope) that the error also gets propagated back into the public
API for the call, where it can be caught by applications.

Is there an advantage to exposing that for applications as opposed to
just having them check the return values from existing API?  (My
application checks every return value)

Ok, it looks like ssh_socket_get_status() already gives you
SSH_CLOSED_ERROR in this case.

> and if it is closed.

It looks to me like we close on any error, and further calls should
return errors.  

But if you think it'd be useful I'm happy to add it.

[PATCH 2/3] Add ssh_get_poll_flags()Colin Walters <walters@xxxxxxxxxx>
Re: [PATCH 2/3] Add ssh_get_poll_flags()Andreas Schneider <asn@xxxxxxxxxxxxxx>
Archive administrator: postmaster@lists.cynapses.org