[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Support for SHA2 HMAC algorithms


Hi Andreas,

On 22 Apr 2014, at 09:24, Andreas Schneider <asn@xxxxxxxxxxxxxx> wrote:

> The patch looks great now. Thanks for adding the tests. Could you split up the 
> patch into several patches?
> 
> Especially the implementation and tests. At least those two would be great. 
> More smaller patches would be nice ...
> 
> 
> And you need to add to the commit message(es):
> 
> BUG: https://red.libssh.org/issues/91

I’ve split it up in steps that I think make sense, adding SHA2 algorithms, negotiation and support for setting options. Let me know if I need to do anything else.

— 
Dirkjan


Attachment: 0001-Add-SHA2-algorithms-for-HMAC.patch
Description: Binary data

Attachment: 0002-Add-logic-to-support-SHA2-HMAC-algorithms.patch
Description: Binary data

Attachment: 0003-Add-negotiation-for-SHA2-HMAC-algorithms.patch
Description: Binary data

Attachment: 0004-Add-options-support-for-setting-and-getting-HMAC-alg.patch
Description: Binary data

Attachment: 0005-Add-tests-for-SHA2-HMAC-algorithms.patch
Description: Binary data


Follow-Ups:
Re: Support for SHA2 HMAC algorithmsAndreas Schneider <asn@xxxxxxxxxxxxxx>
References:
Support for SHA2 HMAC algorithmsDirkjan Bussink <d.bussink@xxxxxxxxx>
Re: Support for SHA2 HMAC algorithmsAris Adamantiadis <aris@xxxxxxxxxxxx>
Re: Support for SHA2 HMAC algorithmsDirkjan Bussink <d.bussink@xxxxxxxxx>
Re: Support for SHA2 HMAC algorithmsAndreas Schneider <asn@xxxxxxxxxxxxxx>
Archive administrator: postmaster@lists.cynapses.org