[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: sftp_utimes() uses wrong subsecond unit
[Thread Prev] | [Thread Next]
- Subject: Re: sftp_utimes() uses wrong subsecond unit
- From: Andreas Schneider <asn@xxxxxxxxxxxxxx>
- Reply-to: libssh@xxxxxxxxxx
- Date: Tue, 08 Sep 2015 18:19:37 +0200
- To: libssh@xxxxxxxxxx
On Tuesday, August 25, 2015 04:37:02 PM Tilo Eckert wrote: > Hi, > > I think the subsecond handling in sftp_utimes() is wrong. It takes two > "struct timeval" as parameter which contain the tv_usec field. That > field is in microseconds. However, all the Xtime_nseconds fields of > sftp_attributes_struct are in nanoseconds. Hence, a multiplication by > 1000 is missing. We need a test and a patch for it if it is wrong. I'm improving the test suite right now. We should be able to do much more and better testing soon. -- andreas
Archive administrator: postmaster@lists.cynapses.org