[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] basic client certificate support for libssh


Hi again,

Turns out the earlier stuff somehow forgot gcrypt altogether, hence the
warnings. I've now corrected warnings and gcrypt support.

The attached files also contain the remaining changes from the earlier
patches, from the current master (one per source file to match the
requested style). If you only need the gcrypt related changes, that's patch
#4. I've also adjusted the tests for cmocka (patch #5).

Thanks!


On Tue, Sep 22, 2015 at 6:57 AM Andreas Schneider <asn@xxxxxxxxxxxxxx>
wrote:

> On Monday 21 September 2015 14:20:14 Axel Eppe wrote:
> > Hi Andreas,
> >
> > Sorry for the delayed response, I just got back from travels.
> >
> > Thanks for merging the other patches (and for fixing the 2 leaks on
> error,
> > I wrongly assumed the add_* functions allocating memory would free it on
> > failure).
> >
> > Re: failed test, interestingly it was successful (with gcrypt enabled)
> when
> > I sent the patch, I can only assume there's a conflict with one of the
> > recent changes. I just need to finish updating my env (cmocka was out of
> > date, etc), but I'll get at it this week.
>
> Great thanks, please fix the gcrypt warnings.
>
>
> I'm working on cwrap to get a new release of the wrappers out so we have
> the
> new testing infrastructure in place ...
>
>
>         -- andreas
>
> --
> Andreas Schneider                   GPG-ID: CC014E3D
> www.cryptomilk.org                asn@xxxxxxxxxxxxxx
>
>

Attachment: 0002-auth-Add-cert-auth-support-to-ssh_userauth_publickey.patch
Description: Binary data

Attachment: 0003-agent-Add-cert-auth-support-to-ssh_agent_get_next_id.patch
Description: Binary data

Attachment: 0005-torture_auth-Add-torture_auth_agent_with_cert-test.patch
Description: Binary data

Attachment: 0004-pki_gcrypt-Add-cert-auth-support-to-pki_publickey_to.patch
Description: Binary data

Attachment: 0001-pki_crypto-Add-cert-auth-support-to-pki_publickey_to.patch
Description: Binary data


References:
Re: [PATCH] basic client certificate support for libsshAndreas Schneider <asn@xxxxxxxxxxxxxx>
Re: [PATCH] basic client certificate support for libsshAxel Eppe <aeppe@xxxxxxxxxx>
Re: [PATCH] basic client certificate support for libsshAndreas Schneider <asn@xxxxxxxxxxxxxx>
Archive administrator: postmaster@lists.cynapses.org