Re: Build libssh against openssl 1.1.0

[Andreas Schneider <asn@xxxxxxxxxxxxxx>]

On Monday, 7 November 2016 10:44:12 CET Jakub Jelen wrote:
> On 11/05/2016 05:02 PM, Andreas Schneider wrote:
> > On Wednesday, 2 November 2016 17:58:01 CET Jakub Jelen wrote:
> >> Andreas,
> >> thank you for the comments. I reworked the patch (attached) to smaller
> >> parts that finally build and passes the testsuite in master for both
> >> OpenSSL versions (sorry for the first bad version). It also improves the
> >> readability of some constructions according to your hints.
> > 
> > Thank you very much. I split up one patch which didn't have your sign off.
> > The patchset is attached. I need your ok to add your sign-off and push
> > it.
> Thank you,
> I attached the patch with missing sign-off (sorry, I missed that this time).
> 
> After reading the patch once more, the initialization in the
> src/wrapper.c is probably bogus, because the initialization is done in
> evp_cipher_init(), which is called from both
> evp_cipher_set_encrypt_key() and evp_cipher_set_decrypt_key(), which
> should always come before other cipher operations, isn't it (already in
> the attached patch)?
> 
> About the other patch I am not sure if I am the right one to review, but
> conceptually it looks good.
> 
> Regards,

I didn't test it, but your patchset broke gcrypt support. Could you fix it?


https://test.libssh.org/viewBuildError.php?buildid=37488


Thanks!

-- 
Andreas Schneider                   GPG-ID: CC014E3D
www.cryptomilk.org                asn@xxxxxxxxxxxxxx