Re: [PATCH 5/5] misc: relax fatal errors in ssh_analyze_banner
- Subject: Re: [PATCH 5/5] misc: relax fatal errors in ssh_analyze_banner
- From: Aris Adamantiadis <aris@xxxxxxxxxxxx>
- Reply-to: libssh@xxxxxxxxxx
- Date: Tue, 18 Jul 2017 18:25:58 +0200
- To: libssh@xxxxxxxxxx
I think that if the OpenSSH version can't be parsed, it probably means
it wouldn't be reliable anyway, and fall back to "non-openssh" mode
(which would work fine anyway). So this patch is ok for me.
I don't even remember why we attempt to detect OpenSSH versions, but
it's not security related so we don't really care if some features stop
working when the banner was changed.
On 18/07/17 09:35, Andreas Schneider wrote:
> On Thursday, 13 July 2017 00:40:52 CEST Jon Simons wrote:
> what do you think?
> Should we make it configureable via an option or just be more graceful?
Archive administrator: firstname.lastname@example.org