[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/5] misc: relax fatal errors in ssh_analyze_banner

On Tuesday, 18 July 2017 18:25:58 CEST Aris Adamantiadis wrote:
> Hi Andreas,
> I think that if the OpenSSH version can't be parsed, it probably means
> it wouldn't be reliable anyway, and fall back to "non-openssh" mode
> (which would work fine anyway). So this patch is ok for me.
> I don't even remember why we attempt to detect OpenSSH versions, but
> it's not security related so we don't really care if some features stop
> working when the banner was changed.

We rely on the openssh version mostly for openssh extensions. If we are 
connected to a version which we know supports the feature we turn it on.

I will add the patch.


Andreas Schneider                   GPG-ID: CC014E3D
www.cryptomilk.org                asn@xxxxxxxxxxxxxx

Archive administrator: postmaster@lists.cynapses.org