[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Missing signed-off for pkg chacha20 patches


On Saturday, 9 June 2018 01:58:57 CEST Jon Simons wrote:
> On 6/8/18 7:09 AM, Andreas Schneider wrote:
> > I'm currently working on chacha20 to merge Aris his work. There are two
> > pkd
> > patches from you which don't have a Signed-off-by tag from you.
> > 
> > Could you please give me the permission to add it or send the attached
> > patch back with them?
> > 
> > Also, could you test this patchset?
> 
> Excited to see the chacha20 work headed to master.
> 
> I gave the patchset some review and testing this afternoon and I've attached
> a respin of the patchset that includes:
> 
>  * fixes for current master pkd:
> https://www.libssh.org/archive/libssh/2018-05/0000009.html * the older
> chacha20 patches now with my Signed-off
>  * a couple of minor adjustments plus fix for the mbedTLS build
> 
> These should apply cleanly on to 0940b0f29b4fef86e56dffdd13d978f9692b78fc.
> 
> I tested this series with these combinations of pkd:
> 
>  * Debian Jessie with OpenSSL 1.0.1, libgcrypt20
>  * Debian Stretch with OpenSSL 1.1.0, libgcrypt20, mbedTLS
> 
> Please let me know if I can be of any further help or if you'd like to
> see any changes to the adjustments I made.  I can also send out the patches
> in another format if that would be helpful.

Thanks for your help! I will review and push in the next days.

FYI: We've set up a libssh-mirror on gitlab.

https://gitlab.com/libssh/libssh-mirror

It is just a mirror but you can create pull request against it to get CI runs! 
Currently we cover some distros on x86_64 and openssl 1.0 and 1.1. And we have 
at least one arm64 target (sponsored by RH).


	Andreas



References:
Missing signed-off for pkg chacha20 patchesAndreas Schneider <asn@xxxxxxxxxxxxxx>
Re: Missing signed-off for pkg chacha20 patchesJon Simons <jon@xxxxxxxxxxxxx>
Archive administrator: postmaster@lists.cynapses.org