Re: Missing signed-off for pkg chacha20 patches

[Andreas Schneider <asn@xxxxxxxxxxxxxx>]

On Saturday, 9 June 2018 01:58:57 CEST Jon Simons wrote:
> On 6/8/18 7:09 AM, Andreas Schneider wrote:
> > I'm currently working on chacha20 to merge Aris his work. There are two
> > pkd
> > patches from you which don't have a Signed-off-by tag from you.
> > 
> > Could you please give me the permission to add it or send the attached
> > patch back with them?
> > 
> > Also, could you test this patchset?
> 
> Excited to see the chacha20 work headed to master.
> 
> I gave the patchset some review and testing this afternoon and I've attached
> a respin of the patchset that includes:
> 
>  * fixes for current master pkd:
> https://www.libssh.org/archive/libssh/2018-05/0000009.html * the older
> chacha20 patches now with my Signed-off
>  * a couple of minor adjustments plus fix for the mbedTLS build
> 
> These should apply cleanly on to 0940b0f29b4fef86e56dffdd13d978f9692b78fc.
> 
> I tested this series with these combinations of pkd:
> 
>  * Debian Jessie with OpenSSL 1.0.1, libgcrypt20
>  * Debian Stretch with OpenSSL 1.1.0, libgcrypt20, mbedTLS
> 
> Please let me know if I can be of any further help or if you'd like to
> see any changes to the adjustments I made.  I can also send out the patches
> in another format if that would be helpful.

torture_algorithms_chacha20_poly1305 segfaults on fedora 28. However if I run 
the test with valgrind the output doesn't really make sense.

==3034== Invalid read of size 8                                                                                                                                          
==3034==    at 0x424B86: ssh_options_set_algo (options.c:179)                                                                                                            
==3034==    by 0x425A8E: ssh_options_set (options.c:750)                                                                                                                 
==3034==    by 0x40FD24: test_algorithm (torture_algorithms.c:104)                                                                                                       
==3034==    by 0x410443: torture_algorithms_chacha20_poly1305 
(torture_algorithms.c:282)                                                                                 
==3034==    by 0x586BBB6: ??? (in /usr/lib64/libcmocka.so.0.4.1)                                                                                                         
==3034==    by 0x586C3FC: _cmocka_run_group_tests (in /usr/lib64/libcmocka.so.
0.4.1)                                                                                     
==3034==    by 0x410856: torture_run_tests (torture_algorithms.c:493)
==3034==    by 0x41243C: main (torture.c:838)
==3034==  Address 0x7f3edb0 is 976 bytes inside a block of size 1,112 free'd
==3034==    at 0x4C2FD05: realloc (vg_replace_malloc.c:785)
==3034==    by 0x6ECFFD8: __add_to_environ (in /usr/lib64/libc-2.27.so)                                                                                                  
==3034==    by 0x4C35CBF: setenv (vg_replace_strmem.c:2043)
==3034==    by 0x411A7D: torture_setup_socket_dir (torture.c:547)                                                                                                        
==3034==    by 0x411F88: torture_setup_sshd_server (torture.c:730)                                                                                                       
==3034==    by 0x40F9BD: sshd_setup (torture_algorithms.c:37)
==3034==    by 0x586BC52: ??? (in /usr/lib64/libcmocka.so.0.4.1)
==3034==    by 0x586C267: _cmocka_run_group_tests (in /usr/lib64/libcmocka.so.
0.4.1)
==3034==    by 0x410856: torture_run_tests (torture_algorithms.c:493)
==3034==    by 0x41243C: main (torture.c:838)
==3034==  Block was alloc'd at
==3034==    at 0x4C2DAE8: malloc (vg_replace_malloc.c:298)
==3034==    by 0x4C2FD4F: realloc (vg_replace_malloc.c:785)
==3034==    by 0x6ECFFD8: __add_to_environ (in /usr/lib64/libc-2.27.so)
==3034==    by 0x4C35CBF: setenv (vg_replace_strmem.c:2043)
==3034==    by 0x411A65: torture_setup_socket_dir (torture.c:546)
==3034==    by 0x411F88: torture_setup_sshd_server (torture.c:730)
==3034==    by 0x40F9BD: sshd_setup (torture_algorithms.c:37)
==3034==    by 0x586BC52: ??? (in /usr/lib64/libcmocka.so.0.4.1)
==3034==    by 0x586C267: _cmocka_run_group_tests (in /usr/lib64/libcmocka.so.
0.4.1)
==3034==    by 0x410856: torture_run_tests (torture_algorithms.c:493)
==3034==    by 0x41243C: main (torture.c:838)


	Andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
www.cryptomilk.org                asn@xxxxxxxxxxxxxx