Re: Missing signed-off for pkg chacha20 patches

[Andreas Schneider <asn@xxxxxxxxxxxxxx>]

On Wednesday, 20 June 2018 20:19:57 CEST Jon Simons wrote:
> On 6/20/18 8:49 AM, Andreas Schneider wrote:> I'm having OpenSSH 7.7 and it
> looks like blowfish_cbc support has been removed
> > in OpenSSH 7.6.
> 
> ...
> 
> > We either need to remove it or disable the tests if ssh version is >= 7.6.
> 
> I am comfortable to simply remove it from the pkd tests.  Attached is
> a patch which unconditionally removes all of the blowfish-cbc passes.
> The patch should apply cleanly to the previous larger series.

I'm sorry but I'm still having issues running the pkd tests :-(

$ cat tests/pkd/torture_pkd_dropbear_dsa_hmac_sha2_512.err                                                                   
WARNING: Ignoring unknown option -v
dbclient: This Dropbear program does not support 'hmac-sha2-512' MAC algorithm

dbclient: Exited: No valid MACs specified for '-m'
$ rpm -q dropbear
dropbear-2018.76-2.fc28.x86_64

dbclient -m help foo
dbclient: Available MACs:
hmac-sha1-96,hmac-sha1,hmac-sha2-256


Somehow hmac-sha2-512 doesn't seem to be supported. I've opened:

https://bugzilla.redhat.com/show_bug.cgi?id=1593457


Also can you disable the dropbear tests if dbclient hasn't been found?


You can also use find_program() in cmake and set it in a 'pkd_config.h' like 
file if it is available or not.

You can also do parsing of ssh options with cmake if this makes it easier ...


	Andreas