Review of SSH1 code removal

[Jakub Jelen <jjelen@xxxxxxxxxx>]

Changeset:
https://git.libssh.org/users/asn/libssh.git/commit/?h=master-ssh1


client.c:
             /* If SSHv1 is disabled, we can send the banner immedietly
*/

 -- there is no need to leave comments referencing ssh1 anymore. 


obj/build_make.sh
                      OPTIONS="${OPTIONS} -DWITH_SSH1=ON"

 -- This should not reference SSH1 either

buffer.{c,h}

struct ssh_string_struct *ssh_buffer_get_mpint(struct ssh_buffer_struct
*buffer) {

 -- this function is unused: * @note This function is SSH-1 only.


I am wondering what about the SSH_KEYTYPE_RSA1 key format. This is used
all over the code and (even though it is probably unreachable) it
should go away too. There is no good use of these keys in SSH2.

Otherwise the changes look good and running the tests on this branch
gives no error.


Regards,
-- 
Jakub Jelen
Software Engineer
Security Technologies
Red Hat, Inc.