Re: [PATCH] sftpserver: Support some openssh extensions

[Alberto Aguirre <albaguirre@xxxxxxxxx>]

Ooops, I forgot about the sign-off.

I'll resend it.
On Mon, Aug 27, 2018 at 2:37 AM Andreas Schneider <asn@xxxxxxxxxxxxxx> wrote:
>
> On Thursday, 23 August 2018 21:13:09 CEST Alberto Aguirre wrote:
> > From: Chris Townsend <christopher.townsend@xxxxxxxxxxxxx>
> >
> > Add support for "hardlink@xxxxxxxxxxx" and
> > "posix-rename@xxxxxxxxxxx" extensions.
>
>
> Hello Alberto and Chris,
>
> first the patch doesn't have any Sign-Off, please check SubmittingPatches file
> in the git repo or source tarball.
>
> Second, the sftpserver implementation is old and what we really would need is
> a rewrite to use callbacks instead, like the rest of the libssh server
> implementation. This would make a lot of things easier.
>
> However if you need this patch, we could add it if it gets signed-off :-)
>
>
> Cheers,
>
>
>         Andreas
>
> --
> Andreas Schneider                 asn@xxxxxxxxxxxxxx
> GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D
>
>