Re: [PATCH] Add support for diffie-hellman-group16-sha512

[Andreas Schneider <asn@xxxxxxxxxxxxxx>]

On Monday, 10 September 2018 17:26:48 CEST Aris Adamantiadis wrote:
> Hi Anderson,
> 
> Thanks for your contribution. I am not particularly fond of hardcoded DH
> groups such as group14 or group16, especially since we have
> dh-group-exchange now. Is it needed to connect to some device that has
> group16 but doesn't have dh-gex?

We don't have dh-gex yet. I wasn't able to fully integrate your branch yet. 
Some patches did not work and broke out testsuite.

https://git.libssh.org/users/aris/libssh.git/commit/?
h=gex_aris&id=7f136b56c95e5898095eec1f8daf8c255f23c139

https://git.libssh.org/users/aris/libssh.git/commit/?
h=gex_aris&id=2666a2f4de2ba4fb342197bcb3a9bc3ece0afda7

There is a but somewhere in those to patches which need to be fixed first. I 
haven't had the time to look into it yet.
 
> Thanks,
> 
> Aris
> 
> On 10/09/2018 15:30, Anderson Sasaki wrote:
> > Hello,
> > 
> > Follows attached a patch which adds support for
> > diffie-hellman-group16-sha512.
> > 
> > It can also be reviewed in:
> > 
> > https://gitlab.com/ansasaki/libssh-mirror/merge_requests/11
> > 
> > Best Regards,
> > Anderson


-- 
Andreas Schneider                 asn@xxxxxxxxxxxxxx
GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D